Codecov Report

Base: 86.52% // Head: 86.48% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (9d50709) compared to base (c113c00).
Patch coverage: 100.00% of modified lines in pull request are covered.

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   86.52%   86.48%   -0.04%     
==========================================
  Files          89       89              
  Lines       34046    34046              
==========================================
- Hits        29457    29445      -12     
- Misses       4589     4601      +12     

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

The logic is sound. I started an AWCY run on objective-1-fast at default speed:

I think the confounding factor is that this function is called for motion estimation on subsampled frames.

@barrbrain I also saw your other commit (barrbrain@5b45ccf)

At least for me, it wasn't obvious at first that it changes the rate curve itself rather than just the rounding (see below)

https://www.desmos.com/calculator/ekdizwd572

perhaps the rate curve could somehow be adjusted for better gains? I'll look into it further

@barrbrain I also saw your other commit (barrbrain@5b45ccf)

This was a mistake, I shouldn't have changed the scale.

I tried another experiment which gave modest gains on top of the rounding change, barrbrain@7baa93f :
"Do not round in get_mv_rate except for original resolution"

However, the more surprising result was that if that change were applied first, the rounding change had no impact on decisions.

Compared to the baseline, results for this experiment were a wash:

Hmm, I'll mark this as draft for now then unless I can find an improvement later on